Skip to content

Conversation

marekdedic
Copy link
Contributor

Closes #1109

I added parsing of both prefixes and suffixes in cases with dynamic values. If the whole value is dynamic, the rule just gives up for classes/IDs in that component.

Copy link

changeset-bot bot commented Mar 20, 2025

🦋 Changeset detected

Latest commit: 2f5b83c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@2f5b83c

Published Instant Preview Packages:

View Commit

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ota-meshi ota-meshi merged commit 87c74fe into sveltejs:main Apr 30, 2025
16 of 17 checks passed
@marekdedic marekdedic deleted the consistent-selector-style-dynamic-values branch May 3, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

consistent-selector-style: What to do with dynamic class/ID names?

2 participants